The following document contains the results of Checkstyle.
Files | Infos | Warnings | Errors |
---|---|---|---|
6 | 0 | 0 | 395 |
Files | I | W | E |
---|---|---|---|
org/molwind/servlet/AbstractCommand.java | 0 | 0 | 113 |
org/molwind/servlet/Command.java | 0 | 0 | 14 |
org/molwind/servlet/GetImageCommand.java | 0 | 0 | 79 |
org/molwind/servlet/GetWorldNamesCommand.java | 0 | 0 | 40 |
org/molwind/servlet/MolwindServlet.java | 0 | 0 | 148 |
org/molwind/servlet/package.html | 0 | 0 | 1 |
Rules | Violations | Severity |
---|---|---|
PackageHtml | 1 | Error |
NewlineAtEndOfFile | 4 | Error |
Translation | 0 | Error |
JavadocMethod | 6 | Error |
JavadocType | 0 | Error |
JavadocVariable | 5 | Error |
JavadocStyle | 15 | Error |
ConstantName | 0 | Error |
LocalFinalVariableName | 0 | Error |
LocalVariableName | 0 | Error |
MemberName | 1 | Error |
MethodName | 0 | Error |
PackageName | 0 | Error |
ParameterName | 0 | Error |
StaticVariableName | 0 | Error |
TypeName | 0 | Error |
AvoidStarImport | 3 | Error |
IllegalImport | 0 | Error |
RedundantImport | 0 | Error |
UnusedImports | 12 | Error |
FileLength | 0 | Error |
LineLength | 9 | Error |
MethodLength | 0 | Error |
ParameterNumber | 0 | Error |
EmptyForIteratorPad | 0 | Error |
MethodParamPad | 0 | Error |
NoWhitespaceAfter | 0 | Error |
NoWhitespaceBefore | 0 | Error |
OperatorWrap | 0 | Error |
ParenPad | 18 | Error |
TypecastParenPad | 0 | Error |
TabCharacter | 131 | Error |
WhitespaceAfter | 19 | Error |
WhitespaceAround | 58 | Error |
ModifierOrder | 0 | Error |
RedundantModifier | 1 | Error |
AvoidNestedBlocks | 0 | Error |
EmptyBlock | 0 | Error |
LeftCurly | 0 | Error |
NeedBraces | 0 | Error |
RightCurly | 1 | Error |
AvoidInlineConditionals | 0 | Error |
DoubleCheckedLocking | 0 | Error |
EmptyStatement | 0 | Error |
EqualsHashCode | 0 | Error |
HiddenField | 0 | Error |
IllegalInstantiation | 0 | Error |
InnerAssignment | 0 | Error |
MagicNumber | 0 | Error |
MissingSwitchDefault | 0 | Error |
RedundantThrows | 1 | Error |
SimplifyBooleanExpression | 0 | Error |
SimplifyBooleanReturn | 0 | Error |
DesignForExtension | 8 | Error |
FinalClass | 0 | Error |
HideUtilityClassConstructor | 0 | Error |
InterfaceIsType | 0 | Error |
VisibilityModifier | 2 | Error |
ArrayTypeStyle | 0 | Error |
FinalParameters | 12 | Error |
GenericIllegalRegexp
|
88 | Error |
TodoComment | 0 | Error |
UpperEll | 0 | Error |
Violation | Message | Line |
---|---|---|
File does not end with a newline. | 0 | |
Using the '.*' form of import should be avoided - org.jdom.*. | 21 | |
Using the '.*' form of import should be avoided - java.io.*. | 24 | |
First sentence should end with a period. | 27 | |
Line has trailing spaces. | 28 | |
'{' is not preceded with whitespace. | 35 | |
Line has trailing spaces. | 37 | |
First sentence should end with a period. | 38 | |
Line is longer than 80 characters. | 39 | |
Line has trailing spaces. | 40 | |
Method 'writeXML' is not designed for extension - needs to be abstract, final or empty. | 48 | |
Parameter response should be final. | 48 | |
',' is not followed by whitespace. | 48 | |
Parameter array should be final. | 48 | |
'{' is not preceded with whitespace. | 48 | |
Line has trailing spaces. | 49 | |
Line contains a tab character. | 49 | |
Line contains a tab character. | 50 | |
Line contains a tab character. | 51 | |
Line contains a tab character. | 52 | |
Line contains a tab character. | 53 | |
Line has trailing spaces. | 55 | |
Line contains a tab character. | 55 | |
Line contains a tab character. | 58 | |
Line has trailing spaces. | 61 | |
Line contains a tab character. | 61 | |
Line contains a tab character. | 62 | |
'=' is not preceded with whitespace. | 62 | |
'=' is not followed by whitespace. | 62 | |
Line has trailing spaces. | 63 | |
Line has trailing spaces. | 65 | |
Line contains a tab character. | 65 | |
Line contains a tab character. | 66 | |
'for' is not followed by whitespace. | 66 | |
':' is not preceded with whitespace. | 66 | |
':' is not followed by whitespace. | 66 | |
'{' is not preceded with whitespace. | 66 | |
Line has trailing spaces. | 67 | |
Line contains a tab character. | 67 | |
Line contains a tab character. | 68 | |
Line contains a tab character. | 69 | |
',' is not followed by whitespace. | 69 | |
Line contains a tab character. | 70 | |
Line contains a tab character. | 72 | |
Line contains a tab character. | 73 | |
Line has trailing spaces. | 74 | |
Line contains a tab character. | 74 | |
Line has trailing spaces. | 75 | |
Line contains a tab character. | 75 | |
Line contains a tab character. | 76 | |
Line contains a tab character. | 81 | |
Line contains a tab character. | 82 | |
'try' is not followed by whitespace. | 82 | |
'{' is not preceded with whitespace. | 82 | |
Line contains a tab character. | 83 | |
Line contains a tab character. | 84 | |
',' is not followed by whitespace. | 84 | |
Line contains a tab character. | 85 | |
'catch' is not preceded with whitespace. | 85 | |
'}' is not followed by whitespace. | 85 | |
'catch' is not followed by whitespace. | 85 | |
'{' is not preceded with whitespace. | 85 | |
Line contains a tab character. | 86 | |
Line contains a tab character. | 87 | |
Line has trailing spaces. | 88 | |
Line contains a tab character. | 88 | |
Line has trailing spaces. | 89 | |
Line contains a tab character. | 89 | |
Method 'writeXML' is not designed for extension - needs to be abstract, final or empty. | 91 | |
Missing a Javadoc comment. | 91 | |
Parameter response should be final. | 91 | |
',' is not followed by whitespace. | 91 | |
Parameter array should be final. | 91 | |
'{' is not preceded with whitespace. | 91 | |
Line has trailing spaces. | 92 | |
Line contains a tab character. | 92 | |
Line contains a tab character. | 93 | |
Line contains a tab character. | 94 | |
Line contains a tab character. | 95 | |
Line contains a tab character. | 97 | |
Line has trailing spaces. | 98 | |
Line contains a tab character. | 98 | |
Line contains a tab character. | 99 | |
Line contains a tab character. | 101 | |
'for' is not followed by whitespace. | 101 | |
':' is not preceded with whitespace. | 101 | |
':' is not followed by whitespace. | 101 | |
'{' is not preceded with whitespace. | 101 | |
Line contains a tab character. | 102 | |
Line contains a tab character. | 103 | |
',' is not followed by whitespace. | 103 | |
Line contains a tab character. | 104 | |
Line contains a tab character. | 106 | |
Line contains a tab character. | 107 | |
Line contains a tab character. | 108 | |
Line contains a tab character. | 109 | |
Line contains a tab character. | 110 | |
'try' is not followed by whitespace. | 110 | |
'{' is not preceded with whitespace. | 110 | |
Line contains a tab character. | 111 | |
Line contains a tab character. | 112 | |
',' is not followed by whitespace. | 112 | |
Line contains a tab character. | 113 | |
'catch' is not preceded with whitespace. | 113 | |
'}' is not followed by whitespace. | 113 | |
'catch' is not followed by whitespace. | 113 | |
'{' is not preceded with whitespace. | 113 | |
Line contains a tab character. | 114 | |
Line contains a tab character. | 115 | |
Line has trailing spaces. | 116 | |
Line contains a tab character. | 116 | |
Line has trailing spaces. | 117 | |
Line contains a tab character. | 117 |
Violation | Message | Line |
---|---|---|
File does not end with a newline. | 0 | |
Unused import - javax.servlet.ServletOutputStream. | 21 | |
Unused import - java.io.IOException. | 23 | |
Unused import - java.io.OutputStream. | 24 | |
First sentence should end with a period. | 27 | |
Line has trailing spaces. | 40 | |
First sentence should end with a period. | 42 | |
Line has trailing spaces. | 47 | |
Line has trailing spaces. | 48 | |
Line has trailing spaces. | 51 | |
Line has trailing spaces. | 52 | |
Line is longer than 80 characters. | 55 | |
Redundant 'public' modifier. | 55 | |
',' is not followed by whitespace. | 55 |
Violation | Message | Line |
---|---|---|
File does not end with a newline. | 0 | |
Unused import - org.molwind.util.MolwindServerConfiguration. | 20 | |
Unused import - org.molwind.view.Tiles. | 23 | |
Unused import - java.io.IOException. | 28 | |
Unused import - java.io.OutputStream. | 29 | |
First sentence should end with a period. | 40 | |
Line has trailing spaces. | 41 | |
Line is longer than 80 characters. | 41 | |
Line has trailing spaces. | 43 | |
'{' is not preceded with whitespace. | 47 | |
Line has trailing spaces. | 48 | |
Missing a Javadoc comment. | 50 | |
Variable 'out' must be private and have accessor methods. | 50 | |
Line has trailing spaces. | 51 | |
Line is longer than 80 characters. | 52 | |
Missing a Javadoc comment. | 52 | |
Name 'DEFAULT_IMGLOCATION' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 52 | |
'=' is not preceded with whitespace. | 52 | |
'=' is not followed by whitespace. | 52 | |
';' is not followed by whitespace. | 52 | |
Missing a Javadoc comment. | 53 | |
'=' is not preceded with whitespace. | 53 | |
'=' is not followed by whitespace. | 53 | |
Missing a Javadoc comment. | 54 | |
Variable 'image' must be private and have accessor methods. | 54 | |
Line has trailing spaces. | 55 | |
Line has trailing spaces. | 60 | |
Missing a Javadoc comment. | 61 | |
Line has trailing spaces. | 67 | |
First sentence should end with a period. | 68 | |
Line has trailing spaces. | 72 | |
First sentence should end with a period. | 73 | |
'=' is not followed by whitespace. | 76 | |
Method 'getImageLocation' is not designed for extension - needs to be abstract, final or empty. | 83 | |
Line contains a tab character. | 84 | |
Method 'setImageLocation' is not designed for extension - needs to be abstract, final or empty. | 91 | |
Parameter newImageLocation should be final. | 91 | |
Line contains a tab character. | 92 | |
Line has trailing spaces. | 95 | |
Line has trailing spaces. | 131 | |
First sentence should end with a period. | 164 | |
Line has trailing spaces. | 169 | |
Line has trailing spaces. | 170 | |
Line has trailing spaces. | 173 | |
Line has trailing spaces. | 174 | |
Line is longer than 80 characters. | 176 | |
Method 'execute' is not designed for extension - needs to be abstract, final or empty. | 176 | |
Parameter request should be final. | 176 | |
',' is not followed by whitespace. | 176 | |
Parameter response should be final. | 176 | |
'{' is not preceded with whitespace. | 176 | |
Line contains a tab character. | 178 | |
Line has trailing spaces. | 179 | |
Line has trailing spaces. | 183 | |
Line has trailing spaces. | 189 | |
Line has trailing spaces. | 190 | |
Line has trailing spaces. | 193 | |
Line has trailing spaces. | 194 | |
Line is longer than 80 characters. | 196 | |
Line contains a tab character. | 207 | |
Line has trailing spaces. | 209 | |
Line contains a tab character. | 209 | |
Line contains a tab character. | 211 | |
Line contains a tab character. | 212 | |
Line contains a tab character. | 213 | |
Line contains a tab character. | 214 | |
Line contains a tab character. | 215 | |
Line has trailing spaces. | 216 | |
Line contains a tab character. | 216 | |
Line has trailing spaces. | 217 | |
Line contains a tab character. | 217 | |
Line contains a tab character. | 218 | |
Line contains a tab character. | 219 | |
Line contains a tab character. | 221 | |
Line contains a tab character. | 223 | |
Line has trailing spaces. | 225 | |
Line contains a tab character. | 225 | |
Line has trailing spaces. | 228 | |
Line contains a tab character. | 228 |
Violation | Message | Line |
---|---|---|
File does not end with a newline. | 0 | |
Unused import - java.io.IOException. | 20 | |
Unused import - java.io.OutputStream. | 21 | |
Unused import - javax.servlet.ServletOutputStream. | 29 | |
First sentence should end with a period. | 32 | |
Line is longer than 80 characters. | 33 | |
Line has trailing spaces. | 34 | |
Line has trailing spaces. | 39 | |
Line has trailing spaces. | 40 | |
Missing a Javadoc comment. | 44 | |
'{' is not preceded with whitespace. | 44 | |
Line has trailing spaces. | 51 | |
First sentence should end with a period. | 54 | |
Line has trailing spaces. | 59 | |
Line has trailing spaces. | 60 | |
Line has trailing spaces. | 63 | |
Line has trailing spaces. | 64 | |
Line is longer than 80 characters. | 66 | |
Method 'execute' is not designed for extension - needs to be abstract, final or empty. | 66 | |
Parameter request should be final. | 66 | |
',' is not followed by whitespace. | 66 | |
Parameter response should be final. | 66 | |
'{' is not preceded with whitespace. | 66 | |
Line is longer than 80 characters. | 67 | |
Line contains a tab character. | 67 | |
'=' is not followed by whitespace. | 67 | |
Line has trailing spaces. | 70 | |
Line contains a tab character. | 70 | |
Line contains a tab character. | 71 | |
Line has trailing spaces. | 72 | |
Line contains a tab character. | 72 | |
Line has trailing spaces. | 73 | |
Line contains a tab character. | 74 | |
',' is not followed by whitespace. | 74 | |
Line has trailing spaces. | 76 | |
Line contains a tab character. | 76 | |
Line has trailing spaces. | 77 | |
Line contains a tab character. | 77 | |
Line has trailing spaces. | 81 | |
Line has trailing spaces. | 83 |
Violation | Message | Line |
---|---|---|
Using the '.*' form of import should be avoided - org.jdom.*. | 21 | |
Unused import - javax.servlet.ServletOutputStream. | 32 | |
Unused import - org.molwind.view.Tiles. | 38 | |
Line has trailing spaces. | 59 | |
First sentence should end with a period. | 60 | |
Line has trailing spaces. | 64 | |
First sentence should end with a period. | 65 | |
'=' is not followed by whitespace. | 68 | |
First sentence should end with a period. | 76 | |
'<' is not preceded with whitespace. | 80 | |
'<' is not followed by whitespace. | 80 | |
',' is not followed by whitespace. | 80 | |
'>' is not preceded with whitespace. | 80 | |
Line has trailing spaces. | 81 | |
Method 'init' is not designed for extension - needs to be abstract, final or empty. | 95 | |
Line contains a tab character. | 97 | |
Line contains a tab character. | 99 | |
'(' is followed by whitespace. | 99 | |
')' is preceded with whitespace. | 99 | |
Line has trailing spaces. | 100 | |
Line contains a tab character. | 104 | |
Line has trailing spaces. | 136 | |
Line has trailing spaces. | 139 | |
Line has trailing spaces. | 140 | |
Line has trailing spaces. | 141 | |
Line has trailing spaces. | 142 | |
Missing a Javadoc comment. | 143 | |
'(' is followed by whitespace. | 143 | |
')' is preceded with whitespace. | 143 | |
Line has trailing spaces. | 144 | |
Line contains a tab character. | 144 | |
Line contains a tab character. | 145 | |
Line contains a tab character. | 146 | |
'<' is not preceded with whitespace. | 146 | |
'<' is not followed by whitespace. | 146 | |
',' is not followed by whitespace. | 146 | |
'>' is not preceded with whitespace. | 146 | |
'>' is not followed by whitespace. | 146 | |
Line contains a tab character. | 147 | |
Line contains a tab character. | 148 | |
'while' is not followed by whitespace. | 148 | |
'(' is followed by whitespace. | 148 | |
')' is preceded with whitespace. | 148 | |
Line contains a tab character. | 149 | |
'cast' is not followed by whitespace. | 149 | |
Line has trailing spaces. | 150 | |
Line contains a tab character. | 150 | |
Line contains a tab character. | 151 | |
'if' is not followed by whitespace. | 151 | |
'(' is followed by whitespace. | 151 | |
'(' is followed by whitespace. | 151 | |
')' is preceded with whitespace. | 151 | |
')' is preceded with whitespace. | 151 | |
Line has trailing spaces. | 152 | |
Line contains a tab character. | 152 | |
Line contains a tab character. | 153 | |
'(' is followed by whitespace. | 153 | |
')' is preceded with whitespace. | 153 | |
Line has trailing spaces. | 154 | |
Line contains a tab character. | 154 | |
Line contains a tab character. | 155 | |
Line contains a tab character. | 156 | |
'(' is followed by whitespace. | 156 | |
')' is preceded with whitespace. | 156 | |
Line has trailing spaces. | 157 | |
Line contains a tab character. | 157 | |
Line contains a tab character. | 158 | |
Line contains a tab character. | 159 | |
Line contains a tab character. | 160 | |
Line has trailing spaces. | 161 | |
Line contains a tab character. | 161 | |
Line contains a tab character. | 162 | |
'if' is not followed by whitespace. | 162 | |
'(' is followed by whitespace. | 162 | |
')' is preceded with whitespace. | 162 | |
'{' is not preceded with whitespace. | 162 | |
Line contains a tab character. | 163 | |
'(' is followed by whitespace. | 163 | |
')' is preceded with whitespace. | 163 | |
';' is not followed by whitespace. | 163 | |
'}' is not preceded with whitespace. | 163 | |
'}' should be on a new line. | 163 | |
Line has trailing spaces. | 164 | |
Line contains a tab character. | 164 | |
Line has trailing spaces. | 165 | |
Line contains a tab character. | 165 | |
Line contains a tab character. | 166 | |
Line contains a tab character. | 167 | |
Line contains a tab character. | 168 | |
Line contains a tab character. | 169 | |
Line contains a tab character. | 170 | |
Line contains a tab character. | 171 | |
Line contains a tab character. | 172 | |
Line contains a tab character. | 173 | |
Line contains a tab character. | 174 | |
Line contains a tab character. | 175 | |
Line contains a tab character. | 176 | |
Line contains a tab character. | 177 | |
Method 'doGet' is not designed for extension - needs to be abstract, final or empty. | 196 | |
Line contains a tab character. | 198 | |
',' is not followed by whitespace. | 198 | |
Expected @throws tag for 'NullPointerException'. | 198 | |
Redundant throws: 'NullPointerException' is unchecked exception. | 198 | |
Line contains a tab character. | 199 | |
Line contains a tab character. | 200 | |
Line has trailing spaces. | 201 | |
Line contains a tab character. | 201 | |
Line contains a tab character. | 202 | |
'if' is not followed by whitespace. | 202 | |
'{' is not preceded with whitespace. | 202 | |
Line contains a tab character. | 203 | |
',' is not followed by whitespace. | 203 | |
Line contains a tab character. | 204 | |
Line has trailing spaces. | 205 | |
Line contains a tab character. | 205 | |
Line has trailing spaces. | 206 | |
Line has trailing spaces. | 207 | |
Line contains a tab character. | 207 | |
Line has trailing spaces. | 251 | |
'{' is not preceded with whitespace. | 252 | |
Line contains a tab character. | 253 | |
Line contains a tab character. | 255 | |
'{' is not preceded with whitespace. | 255 | |
Line contains a tab character. | 256 | |
Line contains a tab character. | 257 | |
'else' is not preceded with whitespace. | 257 | |
'}' is not followed by whitespace. | 257 | |
'else' is not followed by whitespace. | 257 | |
'{' is not preceded with whitespace. | 257 | |
Line contains a tab character. | 258 | |
Line contains a tab character. | 259 | |
Line has trailing spaces. | 297 | |
First sentence should end with a period. | 298 | |
Line has trailing spaces. | 299 | |
Line has trailing spaces. | 304 | |
Parameter key should be final. | 308 | |
',' is not followed by whitespace. | 308 | |
Parameter com should be final. | 308 | |
Expected @param tag for 'com'. | 308 | |
'{' is not preceded with whitespace. | 308 | |
Line contains a tab character. | 310 | |
',' is not followed by whitespace. | 310 | |
Line has trailing spaces. | 312 | |
First sentence should end with a period. | 313 | |
Parameter key should be final. | 322 | |
Expected @param tag for 'key'. | 322 | |
'{' is not preceded with whitespace. | 322 | |
Line contains a tab character. | 323 |
Violation | Message | Line |
---|---|---|
Missing package documentation file. | 0 |