The following document contains the results of FindBugs Report
FindBugs Version is 1.3.8
Threshold is Low
Effort is Default
| Classes | Bugs | Errors | Missing Classes |
|---|---|---|---|
| 135 | 21 | 0 | 0 |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to molvec in org.molwind.chemical.io.GraphMain2.main(String[]) | STYLE | DLS_DEAD_LOCAL_STORE | 217 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unread field: org.molwind.chemical.io.SDFileIterator.currentEntity | PERFORMANCE | URF_UNREAD_FIELD | 80 | Medium |
| Unread field: org.molwind.chemical.io.SDFileIterator.lastEntity | PERFORMANCE | URF_UNREAD_FIELD | 81 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to pathName in org.molwind.chemical.io.SDFileLocator.getWorldPath(String[]) | STYLE | DLS_DEAD_LOCAL_STORE | 228 | Low |
| Dead store to suffix in org.molwind.chemical.io.SDFileLocator.isChemicalFile(String) | STYLE | DLS_DEAD_LOCAL_STORE | 144 | Low |
| org.molwind.chemical.io.SDFileLocator.DEFAULT_SDF_SUFFIX should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | 59 | Medium |
| org.molwind.chemical.io.SDFileLocator.pathNames should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | Not available | Medium |
| Write to static field org.molwind.chemical.io.SDFileLocator.pathNames from instance method org.molwind.chemical.io.SDFileLocator.setPathNames(String) | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 403 | High |
| Private method org.molwind.chemical.io.SDFileLocator.getWorldPath(String[]) is never called | PERFORMANCE | UPM_UNCALLED_PRIVATE_METHOD | 219-239 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Incorrect lazy initialization of static field org.molwind.chemical.model.ChemicalEntity.inChIFactory in org.molwind.chemical.model.ChemicalEntity.getInChiFactory() | MT_CORRECTNESS | LI_LAZY_INIT_STATIC | 201-202 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from org.molwind.model.WorldEntity to org.molwind.chemical.model.ChemicalEntity in org.molwind.chemical.model.SubstructureResolver.identical(WorldEntity, WorldEntity) | STYLE | BC_UNCONFIRMED_CAST | 265 | Low |
| Unchecked/unconfirmed cast from org.molwind.model.WorldEntity to org.molwind.chemical.model.ChemicalEntity in org.molwind.chemical.model.SubstructureResolver.identical(WorldEntity, WorldEntity) | STYLE | BC_UNCONFIRMED_CAST | 266 | Low |
| Exception is caught when Exception is not thrown in org.molwind.chemical.model.SubstructureResolver.getMolecularWeight(IMolecule) | STYLE | REC_CATCH_EXCEPTION | 97 | Low |
| Private method org.molwind.chemical.model.SubstructureResolver.getMolecularWeight(IMolecule) is never called | PERFORMANCE | UPM_UNCALLED_PRIVATE_METHOD | 92-98 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Private method org.molwind.chemical.view.ChemicalTileGenerator.getEmptyImage() is never called | PERFORMANCE | UPM_UNCALLED_PRIVATE_METHOD | 56-62 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to childGraph in org.molwind.chemical.view.ChemicalTopologyManager.calculatePositions() | STYLE | DLS_DEAD_LOCAL_STORE | 142 | Medium |
| Unused field: org.molwind.chemical.view.ChemicalTopologyManager.entityIterator | PERFORMANCE | UUF_UNUSED_FIELD | Not available | Medium |
| Unused field: org.molwind.chemical.view.ChemicalTopologyManager.relationshipResolver | PERFORMANCE | UUF_UNUSED_FIELD | Not available | Medium |
| Field only ever set to null: org.molwind.chemical.view.ChemicalTopologyManager.entities | CORRECTNESS | UWF_NULL_FIELD | Not available | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class org.molwind.chemical.view.ChemicalTopologyManager$1 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | 129-130 | Low |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to font in org.molwind.chemical.view.SubstructureRenderer.renderImage(Dimension, ChemicalEntity, IAtomContainer, HashMap) | STYLE | DLS_DEAD_LOCAL_STORE | 188 | High |